Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Autocomplete sometimes stops working

See original GitHub issue

A summary of the issue and the browser/OS environment in which it occurs.

Issue occurs in both Chrome and Firefox
Reproduced on osx

Steps to Reproduce

Using either Athena or Presto as a data source, type a character that should trigger an autocomplete (e.g. a should autocomplete to avg). The autocomplete dropdown appears
Delete the typed character and type it again.

Expected Behaviour: The dropdown shows up again. Actual Behaviour: The dropdown no longer works after the first time a character is typed and deleted. It works again after refreshing the page but the same issue gets triggered.

Note: This worked fine on other data sources, for example, Redshift. Note: This was reproduced in the mozilla fork of Redash

Issue Analytics

State:
Created 5 years ago
Comments:8 (5 by maintainers)

Top GitHub Comments

1reaction

arikfrcommented, Nov 14, 2018

@emtwo I found out that your fork’s implementation is a bit different than the upstream one, and this is why autocomplete stops working completely and can’t be even triggered with Ctlr+Space.

The issue is here:

https://github.com/mozilla/redash/blob/d1a32370cd4f4fe75c4f3d63d12092817f481235/client/app/components/queries/query-editor.js#L105-L111

Note that in the upstream we don’t disable basic autocomplete, even when tokens count is higher than the threshold:

https://github.com/getredash/redash/blob/8c5e2dffc471db974f11df1102d8f783d9fb1554/client/app/components/queries/query-editor.js#L104-L107

0reactions

emtwocommented, Nov 16, 2018

@arikfr thanks so much for looking into that and for the update! That is super helpful!