Counter Visualization: count rows never shows zero

Issue Summary

If I toggle Count Rows and my query returns no results, the visualization disappears. It should show “0”. It makes sense for the visualization to disappear if it points at a field and row index. But sometimes the number of rows is actually zero and this should be reflected by the counter.

Steps to Reproduce

1. Write a query that returns a single row: SELECT 'foo', 'bar'
2. Add a counter visualization and toggle Count Rows. The counter will show 1.
3. Add a NULL WHERE clause to the query … where 1 =2. The counter disappears.

Technical details:

• Redash Version: 7, 8, 9alpha
• Browser/OS: Firefox / Chrome / Safari
• How did you install Redash: Saas / Docker

[arikfr]

Thank you for taking a look at this.

You need to create a fork on GitHub, push to your fork and make a pull request from there.

On Fri, Nov 22, 2019, 01:45 dmudro [e-mail] wrote:

I wrote a fix for this including bunch of unit tests for client/app/visualizations/counter/utils.js. Am not able to push my branch and create the PR though, getting 403. Maybe @arikfr https://github.com/arikfr can advise?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/getredash/redash/issues/4265?email_source=notifications&email_token=AAAROLGQGGRL5WQOH5JVHX3QU4MTJA5CNFSM4JCGMJEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE4BIRQ#issuecomment-557323334, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAROLCLJQFNNUUWE34ZOIDQU4MTJANCNFSM4JCGMJEA .

[gabrieldutra]

Hi @dmudro thanks for pointing that out, there is #4366 to allow more aggregate functions in the Counter visualization, so the “Count rows” will probably be merged into a “Counter Type” dropdown soon. Regarding the inconvenient non existent value, that seems a bug, I’ll investigate further on that as it should either show a placeholder or select a valid column value by default.