Refactor showModal to avoid having catch everywhere

(follow up to this conversation)

https://github.com/getredash/redash/blob/2755e1275af400b9bca167602d33cfc9b8e52418/client/app/components/tags-control/TagsControl.jsx#L27-L30

@arikfr:

Coudln’t we handle this in showModal instead of having to add this everywhere?

@kravets-levko

Sadly, no After .catch() handler promise will go to next .then() handler, so if we catch that promises inside of dialog wrapper - the caller’s .catch() will not be called. It actually is not a problem, but browser will show unhandled rejection errors in console. We can either:

1. don’t catch that promises and ignore errors in console;
2. always add empty catch handler like I did here;
3. replace browser’s Promise with something else that does not trigger unhandled rejection errors (e.g. “bluebird”) - prior to this PR we used Angular’s $q for this purpose;
4. change a way we handle dialog’s close/dismiss events (for me current flow looks fine, but that annoying unhandled rejections…)

[arikfr]

I don’t think the last suggestion is a good one. There just shouldn’t be an error when there isn’t one 😃

[arikfr]

We could avoid using promises here and just pass a callback for dialog closed and another (optional) for dialog cancelled. This way handler stays the same and we don’t have to abuse a promise.