`sentry_version` clarification
See original GitHub issueAccording to the release log from 1.0.4 of raven-python, sentry_version
is the expected sentry server version. [1]
However, in the unit tests and the latest official sentry Dockerfile as of today, that SENTRY_VERSION has been inconsistent specified: Dockerfile has it defined as ‘8.10’ [2] unit tests in Sentry server has it fixated at ‘2’ [3] and in raven-python
fixated at ‘6’. [4]
So those brought up my question: does sentry_version
actually matter in the header that raven client sent in the header? If not, can we ignore it from the header?
[1] https://github.com/getsentry/raven-python/blob/master/CHANGES#L579 [2] https://github.com/getsentry/docker-sentry/blob/master/8.10/Dockerfile#L56 [3] https://github.com/getsentry/raven-python/blob/master/tests/base/tests.py#L195 [4] https://github.com/getsentry/sentry/blob/master/tests/sentry/web/api/tests.py#L83
Issue Analytics
- State:
- Created 7 years ago
- Comments:6 (3 by maintainers)
Top GitHub Comments
Correct. raven-python sends version 6: https://github.com/getsentry/raven-python/blob/master/raven/base.py#L142
Though the latest version is actually 7, we just don’t require version 7 I guess for raven-python.
Ok, so the latest
sentry_version
that raven-python sends in the header should be ‘6’?https://github.com/getsentry/raven-python/blob/master/CHANGES#L320