Sessions lose cookies

Hi,

It seems that there’s a problem with the mocked HTTP requests returned when using a session - the session cookie is returned in the response object, but does not get set in the session.

I am pretty sure it’s down to the extract_cookies_to_jar function in cookielib/cookies.py:

def extract_cookies_to_jar(jar, request, response):
    """Extract the cookies from the response into a CookieJar.

    :param jar: cookielib.CookieJar (not necessarily a RequestsCookieJar)
    :param request: our own requests.Request object
    :param response: urllib3.HTTPResponse object
    """
    if not (hasattr(response, '_original_response') and
            response._original_response):
        return
    # the _original_response field is the wrapped httplib.HTTPResponse object,
    req = MockRequest(request)
    # pull out the HTTPMessage with the headers and put it in the mock:
    res = MockResponse(response._original_response.msg)
    jar.extract_cookies(res, req)

The _original_response attribute is missing from the mocked HTTPResponse, so no cookies get pulled out into the jar. I’m trying to come up with a solution and if I do I’ll post here, but I should thought I’d let the community at large know. Perhaps I’m doing something silly 😃

[mathewcohle]

Hi,

I want to report that the issue still persists. Following example reproduces it:

import requests
import responses

session = requests.Session()
headers = {'Set-Cookie': 'foo=bar'}

with responses.RequestsMock() as rsps:
    rsps.add(
        responses.GET, 'https://google.com', headers=headers)
    r = session.get('https://google.com')


print(r.cookies)
>>> <RequestsCookieJar[<Cookie foo=bar for />]>

print(session.cookies)
>>> <RequestsCookieJar[]>

$ python --version
Python 3.7.0

$ pip freeze 
responses==0.9.0
requests==2.19.1

[markstory]

Closing as #285 was merged.