Callback not called when sentry is not registered

Package

Sentry

.NET Flavor

.NET

.NET Version

6.0.0

OS

Any (not platform specific)

SDK Version

3.33.1

Self-Hosted Sentry Version

No response

Steps to Reproduce

We have some internal nuget packages that integrate with Sentry if sentry is registered. We currently do something like:

hub = serviceProvider.GetService<IHub>() ?? HubAdapter.Instance;

Now when calling WithScopeAsync when Sentry has not been registered in the .net core app, the code is not called:

await _hub.WithScopeAsync(async scope =>
    ... //This code is not called if sentry is not registered
);

I tracked it down to this line of code: https://github.com/getsentry/sentry-dotnet/blob/410b30d2ce0c4db93c050778249b0d812aff089c/src/Sentry/SentryScopeManagerExtensions.cs#L52

Expected Result

Code is being called even if sentry is not registered

Actual Result

Code is not being called

[Vandersteen]

Thanks for the tips, I’ll have a look.

I guess as the original issue is ‘resolved’ you can go ahead and close this ticket.

I would still be awesome if the callback was still called, but for now we’ll work around that

[jamescrosswell]

I haven’t played too much with the settings (so MaxBreadcrumbs is the default I guess)

OK. That, at the very least, puts a cap on the number of breadcrumbs that can pile up. You’ll only ever have a maximum of 100 per scope (by default). So memory consumption on the application won’t grow indefinitely.

You still have a practical problem of ensuring that you have all the relevant breadcrumbs and they’re not drowned out in the noise of a bunch of irrelevant logs.

There are a couple of tools at your disposal there.

You can set minimum levels when configuring logging:

Log.Logger = new LoggerConfiguration()
  .WriteTo.Sentry(o =>
  {
    // Debug and higher are stored as breadcrumbs (default is Information)
    o.MinimumBreadcrumbLevel = LogEventLevel.Debug;
    // Warning and higher is sent as event (default is Error)
    o.MinimumEventLevel = LogEventLevel.Warning;
  })
  .CreateLogger();

Another is the SetBeforeBreadcrumb hook but you need some way to sift the logs/breadcrumbs you’re interested in from those you’re not. I’m not sure I have any silver bullets there… it might be a matter of playing around to see if there are any obvious markers in combinations of things like Breadcrumb.Type, Breadcrumb.Category or possibly information stored in the Breadcrumb.Data dictionary.