Revert adding Sentry to global usings
See original GitHub issueThe latest Release 3.14.0 comes with the following feature:
Add Sentry to global usings when ImplicitUsings is enabled (<ImplicitUsings>true</ImplicitUsings>) (https://github.com/getsentry/sentry-dotnet/pull/1398)
We do have implicit usings enabled, with the intention was that only the often used “standard”-namespaces are added there. Sentry on the other hand is a namespace which we use exactly once in our ASP.NET Core API projects: when configuring Sentry on startup.
For me as an “end user” of this library it does make absolutely no sense to have Sentry in the global usings.
Main issue:
The main conflict here is Sentry.User
. I guess a User
is not a really uncommon name for a class. Now, with the latest update we have a lot of ambiguous references between Sentry.User and our Domain-User. As a workaround I’d have to explicitly reference our Domain-User in a ton of classes over multiple projects. Which I really don’t want to do.
So I vote for removing Sentry from global usings again.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:5 (4 by maintainers)
Top GitHub Comments
wouldnt this suffice as a opt-out ?
We discussed and agreed to revert this feature, until we release 4.0 that will include renaming some types prone to conflict. Lets spin off a new issue to track the class renames and adding this feature back in.