Calling `Sentry.init()` with empty dsn doesn't throw error

• Review the documentation: https://docs.sentry.io/platforms/javascript/electron/
• Search for existing issues: https://github.com/getsentry/sentry-electron/issues
• Use the latest release: https://github.com/getsentry/sentry-electron/releases

Versions + Platform

• SDK version - @sentry/electron@v^2.5.0
• Electron version - electron@v9.4.4
• Platform - macOS`

Description

If I call Sentry.init({ dsn: "" }) then no error is thrown but instead the follow log line is logged to console.error: SentryError: Attempted to enable Electron native crash reporter but no DSN was supplied.

This is because of the forget call at https://github.com/getsentry/sentry-electron/blob/edd2775048d4658f88fd23a989574da913e6762a/src/main/backend.ts#L101

That function really shouldn’t be async at all since it includes 0 await’s and two forget’s itself.

[timfish]

You can validate a DSN something like this:

import { DSN } from '@sentry/utils';

const dsnString = '[e-mail]';
try {
  const dsn = new DSN(dsnString);
} catch (_) {
  // DSN was invalid
}

[Nokel81]

If you set it to a invalid sdn then I believe it does throw. Would you be willing to expose a validation function then?