Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Client should be able to restore/not remove outcomes in case sending envelope fails

See original GitHub issue

Problem Statement

https://github.com/getsentry/sentry-javascript/blob/fbd4ef07dd4248a1a9f8a80e0c220628a663f91c/packages/core/src/baseclient.ts#L735

_clearOurcomes clear and returns current outcomes and is the only way of retrieving outcomes, but in React Native SDK we need to be able to either restore (or not clear them) the outcomes in case sending the envelope fails (buffer is full at the moment).

Solution Brainstorm

Split this into two methods _getOutcomes and _clearOutcomes so it’s possible to clear outcomes after we know the Envelope was sent successfully.

Would something like this make sense?

Issue Analytics

State:
Created a year ago
Comments:7 (7 by maintainers)

Top GitHub Comments

2reactions

krystofwoldrichcommented, Sep 26, 2022

Yes, it would be possible, I’m thinking about it, because theoretically getting outcomes and clearing them later can cause issues if new outcomes appear meanwhile Im sending the envelope.

So maybe no change will be needed. Thanks for the discussion.

0reactions

lforstcommented, Sep 26, 2022

Other suggestion: Can’t we somehow add outcomes to the buffer in RN after the fact?

Top Results From Across the Web

Client should be able to restore/not remove outcomes in case ...

Split this into two methods _getOutcomes and _clearOutcomes so it's possible to clear outcomes after we know the Envelope was sent successfully. Would...

How do I edit or remove a course outcome group in

If you created an outcome group in your course that you need to edit or remove, you can do so as long as...

All Release Notes - Linode

Guides and tutorials on the Linode platform, Linux basics, and software installation and configuration.

VisNetic MailServer Administrator's Guide Version 8 - CiteSeerX

Additional VisNetic MailServer Documentation is available at: ... In case of the hardware failure you will be able to restore not only.

lQj - River Thames Conditions - Environment Agency - GOV.UK

Vostro 1015 memory, Vaerlandet bulandet, Faith tauiliili, Klasifikasi daun sedingin, Wwe 14 games free download, Gallbladders removed, Lowell observatory ...