Custom exceptions throw globally aren't filtered by whitelistUrls

When some third party code throws a non-Error object, it’s being collected by Raven’s window.onerror handler and being fowarded to captureMessage, which doesn’t use whitelistUrls to filter exceptions.

I’d expect that ALL global exceptions (that get caught by window.onerror) are passed through whitelistUrls, regardless of their type.

Code to reproduce:

  // Set up Raven:
  Raven.config('...', {
    whitelistUrls: [/myfile\.js/],
  });

  // Install window.onerror handler.
  Raven.install();

  setTimeout(function(){
     throw new Error('this will get filtered out by whitelistUrls since this isn\'t being thrown from that file');
  });

  CustomError = function(message) {
    this.message = message;
  };

  setTimeout(function(){
     throw new CustomError('this will make it through!');
  });

This is an issue if you’re including third party libraries on the page that might throw their own custom error object, and not catch it.

[benvinegar]

Will whitelistUrls automatically start filtering global exceptions once we upgrade to 3.4.0?

It already does? For normal exceptions (Error), at least. This changes it so that generic messages caught via captureMessage will also apply whitelistUrls (note that you need stacktrace:true set in config).

[wearhere]

Hey @benvinegar, cool to see this fixed. Will whitelistUrls automatically start filtering global exceptions once we upgrade?