Error message property logged as [object ErrorEvent]

Do you want to request a feature or report a bug? Bug.

What is the current behavior? Sometimes (not always) the message property of the error is logged as [object ErrorEvent]. I followed the standard implementation of Raven in Angular as described here: https://docs.sentry.io/clients/javascript/integrations/angular/.

What is the expected behavior? To see a normal error message.

Raven 3.17.0 Angular 4.3.1 Webpack build Not using CLI CDN version

[GEMI]

Hi, I am getting a lot of these errors [object Object].

Angular 4 Chrome 62.0.3202 Raven-js 3.20.1

[shcallaway]

I found the issue. ErrorEvent is not being treated as an error by the isError util function, which can be found here. For convenience, I’ll paste the function definition also:

function isError(value) {
  switch ({}.toString.call(value)) {
    case '[object Error]':
      return true;
    case '[object Exception]':
      return true;
    case '[object DOMException]':
      return true;
    default:
      return value instanceof Error;
  }
}

I did a quick test in my console to see whether or not this function would return true for an ErrorEvent, and it did not:

isError is used in the captureException method to determine whether the exception parameter is an error or simply a message. captureException will send exceptions to the dashboard using captureMessage if it thinks the exception is not actually an error. In this case, Raven will not compute a stack trace or “process” the exception. It just sends it off as is.

Is there any reason we shouldn’t update isError to return true for ErrorEvent objects?