question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Replay] Migrating sentry-replay into JS SDK mono-repo

See original GitHub issue

Problem Statement

There is the sentry-replay repo which has the Sentry Browser SDK package and rreweb packages as dependencies.

Meaning it has clear requirement dependancies, and similar requirement for CI/CD in terms of testing and creating releases, but cannot easily take advantage of everything which is already part of the JS SDK.

Possible benefits of moving into the JS mono-repo

  • existing test infrastructure
  • monitor file size over across changes
  • existing releases
  • could simplify reuse of code from within the JS SDK and for users to instrument in the future

Concerns: Adds more dependencies into the JS repo, where there is already quite a number of integrations for different browser and Node frameworks, along with all the Sentry features, and SDKs which are dependant on the JS SDK (Electron and react-native)

Solution Brainstorm

Include sentry-replay to be more tightly coupled as part of the Sentry JavaScript SDK mono-repo

Outcomes:

  • https://github.com/getsentry/sentry-replay included in sentry-javascript monorepo
    • can we define here what the ideal import and init will look like? @jas-kas
  • @sentry/replay is available via the CDN bundle (e.g. combined bundle w/ @sentry/browser)
  • Available via lazy loader

Progress

Phase I: Pre-Migration

Phase II: Migration

Phase III: Post-Migration

More long-term tasks are tracked in

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:10 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
smeubankcommented, Oct 24, 2022

@billyvg and @jas-kas we can already start collaborating here if we need to add to this issue, or split it up

1reaction
vladanpaunoviccommented, Oct 24, 2022

One important decision to be made here. Does @sentry/replay follow the same versioning structure as the rest of the repo? If it doesn’t we need to adjust our publishing process around that!

I discussed this with @benvinegar and we agreed that @sentry/replay will follow the same versioning structure as the rest of the monorepo.

We will make sure to highlight in docs and release notes that this is still in alpha before jumping into a stable version.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Migrate sentry-replay into sentry-javascript #6257 - GitHub
We want to migrate https://github.com/getsentry/sentry-replay into this monorepo, as packages/replay. Ensure we keep Git branch history: ...
Read more >
@sentry/hub | Yarn - Package Manager
Fast, reliable, and secure dependency management.
Read more >
Turning a Node.js Monolith into a Monorepo without ... - InfoQ
Migrating a monolithic codebase into a monorepo quickly gets difficult and iterative if the codebase is large, integrated with a lot of tooling ......
Read more >
getsentry/sentry-javascript 7.24.0 on GitHub - NewReleases.io
The Replay version bump is the result of moving the package into the Sentry JavaScript SDK monorepo which aligns the version with our...
Read more >
Managing a full-stack, multipackage monorepo using pnpm
Sharing code in a full-stack JavaScript monorepo ... Don't miss a moment with The Replay, a curated newsletter from LogRocket ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found