Support/make use of Async Hooks

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

6.5.1

Description

I’ve talked about this extensivly in https://github.com/getsentry/sentry-javascript/issues/2172. But since that issue seems to have stalled and others are also seeming to request this (see https://github.com/getsentry/sentry-javascript/issues/2817#issuecomment-756864140) I thought it would be nicer to open an official dedicated issue.

Why:

• Better and out of the box propper transactions and context handling.
• Should fix issues like breadcrumbs not being properly attached to the right error/transaction.
  • See https://github.com/getsentry/sentry-javascript/issues/3120 and https://github.com/getsentry/sentry-javascript/issues/2817#issuecomment-855163926
• Should fix issues of child spans not being correctly attached to the right transaction.
  • See https://github.com/getsentry/sentry-javascript/issues/2172#issuecomment-850447362
• Domains are deprecated and have performance and error handling issues.
  • See https://github.com/getsentry/sentry-javascript/issues/2172#issuecomment-845804452
• Domains don’t seem to actually properly work.
  • See https://github.com/getsentry/sentry-javascript/issues/2172#issuecomment-850447362

Some examples of agents who do use Async Hooks:

• googleapis/cloud-trace-nodejs
  • I can personally confirm this one works out of the box and does tracing correctly
• honeycombio/beeline-nodejs
• elastic/apm-agent-nodejs
• https://github.com/DataDog/dd-trace-js/tree/master/packages/dd-trace

Atm I don’t see how one can use Sentry’s performance offering using Node without this being fixed (unless you only serve 1 request at the same time, which isn’t realistic). I hope I’m missing something since we do want to use your offering but don’t see a way of doing that at this time.

[jasonk]

For anyone else who ends up here hoping to find a way to make Sentry work with async_hooks, I posted a Gist showing how I made this work by using AsyncLocalStorage to create what are effectively thread-local hubs that can make this work better… https://gist.github.com/jasonk/a06153476ae7fad41c527e321e318088

[frimuchkov]

Any updates? There are 2022, Node.js 18 and no async_hooks in sentry 😦