Add support for falcon 3.0
See original GitHub issueCurrently, Falcon ≥ 3.0.0-ALPHA is not supported by Sentry.
Falcon 3.0 renames the API class to APP. This trips the Sentry Falcon integration detection: the import of api_helpers
is renamed to app_helpers
.
Should be a simple fix, roughly:
try:
import falcon # type: ignore
from falcon import __version__ as FALCON_VERSION
try: # from L102
version = tuple(map(int, FALCON_VERSION.split(".")))
except (ValueError, TypeError):
raise DidNotEnable("Unparseable Falcon version: {}".format(FALCON_VERSION))
if version < (3, 0)
import falcon.api_helpers # type: ignore
falcon_helpers = falcon.api_helpers
else:
import falcon.app_helpers # type: ignore
falcon_helpers = falcon.app_helpers
except ImportError:
raise DidNotEnable("Falcon not installed")
and renaming all references to falcon.api_helpers
to falcon_helpers
.
A quick glance shows that PrepareMiddleware
has not changed (returns the same tuple). I can go ahead and open a PR and check if other changes are necessary to support Falcon 3.0 before it comes out of alpha.
Issue Analytics
- State:
- Created 4 years ago
- Comments:15 (3 by maintainers)
Top Results From Across the Web
Add Support for Falcon 3.0.0, 3.0.1 · a6e56ab63c - monasca-api ...
Support to new Falcon 3.0.0 and 3.0.1 keeping compatibility for version 2.0.0 - Remove Falcon's class OptionalRepresentation Starting from Falcon 3.0.0 ...
Read more >Falcon 3.0 Customer Support Question and Answer Booklet
Installation. Q: How do I install Falcon 3.0 to a hard drive? A:. Although Falcon 3.0 is not copy protected in any way,...
Read more >Falcon 3.0 - PCGamingWiki PCGW
Unofficial commercial expansion for Falcon 3.0 that adds a greater degree of customization and planning to the game. Even capable of importing custom...
Read more >Changelog for Falcon 3.0.0 — Falcon 3.1.1 documentation
ASGI+WebSocket support was added to the framework via falcon. · The error classes in falcon. · MultipartFormHandler was added to enable support for...
Read more >Falcon 3.0 (1991) - DOS Days
Supports VGA graphics only. Audio support for PC speaker, Ad Lib, Sound Blaster and Roland MT-32. Supports joystick, Thrustmaster, and math coprocessor.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
any news on that ? It seems that on falcon 3 the exceptions aren’t sent to sentry
Hello all!
We have two PRs from the community for this: https://github.com/getsentry/sentry-python/pull/1073 (For Falcon 3.0.0) https://github.com/getsentry/sentry-python/pull/1297 (For Falcon 3.0.1)
The current plan is to merge those two PRs into one (or pick one of them) and then bring this into shape so it is ready for review.
This could take some time as we want to make this right!