[celery integration] before_send function executed twice

Doing a simple test with sentry and celery integration I see the function before_send gets executed twice when an exception is raised while the on_failure celery task mechanism gets executed correctly once.

Setup:

    # within my make_celery() function to create the celery app

    def before_send(event, hint):
        print('before_send celery integration')
        return event

    sentry_sdk.init(dsn=url, integrations=[CeleryIntegration(), SqlalchemyIntegration()], before_send=before_send)

on_failure celery callback handler

def on_failure(task, exc, task_id, args, _, exception_info, **__):
    logger.error("on_failure error print")

celery task:

@celery.task(bind=True, name="test_sentry_integration", on_failure=on_failure, ignore_result=True)
def test_sentry_integration(_, message):
    raise Exception(message)

output:

[2019-11-15 11:02:13,148: WARNING/ForkPoolWorker-1] test the sdk
[2019-11-15 11:02:13,152: WARNING/ForkPoolWorker-1] before_send celery integration
2019-11-15 11:02:13,159::comfortmanager.common.tasks::ERROR::on_failure error print
[2019-11-15 11:02:13,161: WARNING/ForkPoolWorker-1] before_send celery integration
[2019-11-15 11:02:13,161: ERROR/ForkPoolWorker-1] Task test_sentry_integration[2f5848b3-1e12-4a0d-92e2-0b4dec63e7c8] raised unexpected: Exception('test the sdk',)

Versions:

celery 4.3.0
sentry-sdk 0.13.2

[untitaker]

level controls creation of breadcrumbs (that is, writing them into a local “scrollback” buffer) and event_level controls creation of events. So yes, the INFO logs may appear in the event. However, we wipe breadcrumbs between celery tasks and between HTTP requests (depending on framework), and the buffer is per-thread. So they should be somewhat related to the crash.

[untitaker]

Glad to be of help!