Make sure everything works with Django-Rest-Framework

We should django-rest-framework’s request.data instead of trying to extract a structured body ourselves

[cwmoo740]

It’s somewhat difficult to understand why using sentry with django_rest_framework does not upload request bodies out of the box. There were a few scattered SO and github threads about the problem but the few that I found refer to the older sentry client. I managed to track down the problem and wanted to share my results.

1. DRF uses its own json parser and calls request.read directly, without storing the result on django’s request._body
2. Sentry attempts to read from django’s request.body, which then errors because the stream has already been read and not assigned to request._body

Here are relevant parts of the code that I found:

https://github.com/encode/django-rest-framework/blob/3.9.0/rest_framework/parsers.py#L68

https://github.com/django/django/blob/2.1.5/django/http/request.py#L283

One workaround is to do something silly like this:

@api_view(['POST'])
def my_view(request):
    request.body # side effect of storing the whole request body in memory on request._request._body
    do_something(request.data)

I put up a repo demonstrating this.

https://github.com/cwmoo740/django_sentry_debugging

It would be significantly better imo if there was a separate integration for DjangoRestFramework that simply read from request.data directly and let DRF do the parsing, as you suggested when you opened this thread.

If that work will be accepted I can tackle it and put up a pr.

[untitaker]

0.7.10 was released which should fix this