Minor update 1.9.6 introduces breaking change
See original GitHub issueHow do you use Sentry?
Sentry Saas (sentry.io)
Version
1.9.6
Steps to Reproduce
- Install 1.9.5
- Follow https://docs.sentry.io/platforms/python/guides/asgi/
- Update to 1.9.6
And got the following exception:
RuntimeError: The Sentry Python SDK can now automatically support ASGI frameworks like Starlette and FastAPI.
Please remove 'SentryAsgiMiddleware' from your project.
See https://docs.sentry.io/platforms/python/guides/asgi/ for more information.
Expected Result
- The
SentryAsgiMiddleware
middleware still working, or at least a noop object printing/logging a deprecation warning - A notice that the object will be removed in a future release
- A SemVer major version bump
- A updated documentation and with a section about the library API change and the object deprecation
Actual Result
- project code is not loading anymore
- No deprecation warning
- Minor SemVer change with breaking change
- Documentation still refers to
SentryAsgiMiddleware
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:6 (5 by maintainers)
Top Results From Across the Web
Semantic Versioning 2.0.0 | Semantic Versioning
Semantic Versioning 2.0.0. Summary. Given a version number MAJOR.MINOR.PATCH, increment the: MAJOR version when you make incompatible API changes ...
Read more >RFC: Changes to Vendure's versioning policy #1846 - GitHub
Vendure follows semantic versioning (aka semver). This means that breaking changes are only allowed to be introduced with a major version bump, ...
Read more >Versioning limitations in .NET - Jon Skeet's coding blog
If you make a breaking change, you need to bump the major version; If you make backward compatible additions, you need to bump...
Read more >Anthos clusters on VMware release notes - Google Cloud
To upgrade, see Upgrading Anthos clusters on VMware. ... when connectivity to the Google Cloud metadata service is partially broken. ... Breaking changes:....
Read more >Release History - The Go Programming Language
Release Policy; go1.19 (released 2022-08-02): Minor revisions; go1.18 (released ... This page summarizes the changes between official stable releases of Go.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Here you go: https://github.com/getsentry/sentry-python/releases/tag/1.9.7
I just didn’t expect an application to not start anymore with a library minor update.
Libraries usually print warning that something should not be used anymore and will break at version X.X.X so developers can plan the change.
The doc looks ~ fine even though it’s not clear it’s a deprecation when your use FastAPI
The release changelog does not look great too
Auto-enable Starlette and FastAPI (https://github.com/getsentry/sentry-python/pull/1533) by @antonpirker
I would expect something like:
If you use SentryAsgiMiddleware and FastAPI, your application will break please follow [link-to deprecation doc] to update your code.