Would be helpful to have function decorators for transactions and spans

The current context managers for starting transactions and marking spans are great. However, there have been a few cases where having decorators for transactions and spans would make code simpler to understand. For example celery tasks could be written like

@celery.task
@sentry_sdk.transaction(transaction="celery.update.user" op="job")
def update_user(user_id):
    # Do things

Has less visual noise than the decorator does, and when adding/removing instrumentation the entire function doesn’t change. The same idea applies to spans:

@sentry_sdk.span(description="github.fetch_users", op="github.api")
def fetch_github_users(...):
    # do the api request and data transformations.

The names of the decorators in this issue are likely rubbish, but I think supporting decorators will help make adding instrumentation simpler for end users as it generates less noisy differences and reduces the amount of indentation in their code.

[ynouri]

We have been using those decorators in production on a Python 3.8 FastAPI app for a few months now and they seem to get the job done.

I would be willing to push the PR to the finish line (linting, unit tests) but would prefer to get feedback first. @untitaker any thoughts?

[untitaker]

Yup, has been brought up a couple times. I feel like we may only want this for spans for now.

For transactions I feel like the decorator could push a scope and set an error boundary at the same time as well

On Mon, Jul 13, 2020, 21:52 Mark Story [e-mail] wrote:

The current context managers for starting transactions and marking spans are great. However, there have been a few cases where having decorators for transactions and spans would make code simpler to understand. For example celery tasks could be written like

@celery.task@sentry_sdk.transaction(transaction=“celery.update.user” op=“job”)def update_user(user_id): # Do things

Has less visual noise than the decorator does, and when adding/removing instrumentation the entire function doesn’t change. The same idea applies to spans:

@sentry_sdk.span(description=“github.fetch_users”, op=“github.api”)def fetch_github_users(…): # do the api request and data transformations.

The names of the decorators in this issue are likely rubbish, but I think supporting decorators will help make adding instrumentation simpler for end users as it generates less noisy differences and reduces the amount of indentation in their code.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/getsentry/sentry-python/issues/760, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMPRJB7ZDDYZ5YO2OPVATR3NQXHANCNFSM4OYZZRHQ .