open_in_youtube is outdated
See original GitHub issueHi, it seems like the ‘open_in_youtube’-Skill is not working (at least for me). So ‘jarvis play mozart’ will always tell you ‘I can’t find what do you want in Youtube…’.
I guess yt reworked their searchpage and the old implementation (2 years ago), using bs4 and trying to find the top video via class': 'yt-uix-tile-link'
is not working anymore.
I’m already working on a fix for that. However, i wanted to create this issue first, just to make sure its not a bug/problem only on my side.
So it would be nice if someone can actually confirm that ‘jarvis play xyz’ fails with ‘I can’t find what do you want in Youtube…’.
If so, i’ll publish my fix and create a pullrequest.
Also, it’s the first time for me, contributing to another ones project and providing pull requests. So if i miss anything or could improve something, please just let me know.
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (2 by maintainers)
Top GitHub Comments
As i said, it depends if we want to make a yt-api key mandatory. If so, we could also just go with the origin google-api-python-client, no need for any “middleware”. After all, for now its just a simple request against /search.
Also, did someone consider music.youtube.com? Mby for another skill like “JARVIS play music mozart” (i don’t actually know if theres any difference in the videos/music)? Just stumbled upon https://github.com/sigma67/ytmusicapi
However, lots of possibilities 😄 I guess for now i’ll just upload the simple webscrape-fix, its done anyway and we postpone the yt-api till later.
I really think the simplest way is just using pywhatkit: