Do not require silencer-lib on classpath
See original GitHub issueFirstly, just wanted to say thanks for this plugin! I found it through this bug report in Play.
When using the plugin as described there, I don’t need the @silent
annotation, since I’m only excluding files based on paths rather than with the annotations - so it’s a bit annoying (and ironic 😛) that the plugin generates the following warning:
[warn] `silencer-plugin` was enabled but the @silent annotation was not found on classpath - have you added `silencer-lib` as a library dependency?
Would it be sensible to remove this warning?
Issue Analytics
- State:
- Created 4 years ago
- Comments:6 (3 by maintainers)
Top Results From Across the Web
scala/scala - Gitter
@drewboardman no necessary, a fat JAR is a single jar that contains everything necessary to be run, usually meaning all the code, the...
Read more >com.github.ghik.silencer.SilencerPlugin.scala Maven / Gradle / Ivy
The class is part of the package ➦ Group: com.github.ghik ➦ Artifact: ... was not found on classpath" + " - have you...
Read more >java - JAR under EAR(src/main/application/lib) are not part of ...
Since I am moving an old legacy application to Maven, there were some old references to be cleaned-up. Below changes were required: There...
Read more >Scala Compiler Plugins
You should not actually need to modify the Scala compiler very frequently, ... To use the plugin, a user adds the JAR file...
Read more >boot 2016-09-05 | Slack Archive
@dominicm directories is also tmp dirs and not what you provide in ... c.t.n 0.3 uses clojure.java.classpath and automatically uses the temp ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Ahh of course! This is my mistake: I had the compiler plugin enabled on all my subprojects (which all share the same basic configuration) but of course only enabled the filters on some subprojects (e.g. Play modules). You’re quite right - it absolutely makes sense to still emit the warning in the “vanilla” case.
Thanks (again) for being so responsive 😃
I’ve tested this on a minimal project and it seems to work as intended. Without any options the warning is emitted but when I enable either
messageFilters
orpathFilters
, the warning disappears. Perhaps some of your subprojects lack these options or have the plugin unnecessarily enabled in the first place (maybe the root project in sbt?).This warning was originally introduced to avoid build mistakes like this one. If it turns out to be more annoying than helpful then maybe I should remove it again…