GridService.getSelectedRows return a direct reference of the underlying slickgrid internal array

I’m submitting a Bug report

Your Environment

Software	Version(s)
Angular	8
Angular-Slickgrid	2.x

Context

I noticed that GridService.getSelectedRows return direct reference of underlying slickgrid internal array.

However, I’m not sure whether this is the intended behavior, but it causes some subtle issue when I try to manipulate the return value as shown below:

 this.columnDefinitions2 = [
      {
        id: 'title', name: 'Title', field: 'title',
        sortable: true,
        type: FieldType.string,
        filterable: true,
        onCellClick: (e: Event, args: OnEventArgs) => {
         
         //OK - Able to select the clicked row correctly
         // const selectedRows = [...this.angularGrid2.gridService.getSelectedRows()];

         //NOT OK - Failed to select the clicked row correctly
         const selectedRows = this.angularGrid2.gridService.getSelectedRows();

          // Toggle the clicked row
          const deleteIndex = selectedRows.indexOf(args.row);
          if (deleteIndex >= 0) {
            selectedRows.splice(deleteIndex, 1);
          } else {
            selectedRows.push(args.row);
          }
          this.angularGrid2.gridService.setSelectedRows(selectedRows);
        }
      },

[whtan98]

Will use the spread workaround for time being. Many Thanks

[ghiscoding]

The spread operator makes a deep copy, so it seems that you have pointer issues. I’ll close the issue for now and if more details comes up to help this issue then I can reopen it.