BUG - dispatchEvent should be cancelable

I’m submitting a bug report

Current behavior: All SlickGrid called through EventDispatch should be cancelable, and this requirement is necessary for some of the subscribed event. The event that I currently have problem with is onBeforeEditCell and as answered by the author of SlickGrid in this SO, the way to cancel an edit is to return false which doesn’t do anything when currently used with EventDispatch

Expected/desired behavior:

• What is the expected behavior? EventDispatch should be cancelable

• What is the motivation / use case for changing the behavior? Have the same behavior as regular SlickGrid subscribed event.

[ghiscoding]

I actually found the problem with Angular, I forgot to return the dispatchEvent which is needed to return false

// ... this line
-    this.elm.dispatchEvent(new CustomEvent(eventName, eventInit));
+    return this.elm.dispatchEvent(new CustomEvent(eventName, eventInit));

That could help lol

I will push a commit to address this over the weekend, I will also do them as cancelable on all the dispatchEvent, not just the ones with prefix.

[ghiscoding]

Oh that is interesting, thanks for that, I really didn’t think about changing the arguments as I always do copy & paste lol.

What I like about Aurelia is that they follow the standard and Angular…not so much… and even e.preventDefault() doesn’t prevent the editing. I wouldn’t be surprised that Angular doesn’t handle dispatchEvent event correctly, this might be because in Aurelia we use delegate instead of trigger

I might have to stick with the SlickGrid way until I find the solution (if there is) in Angular

this.onBeforeEditSubscriber = this.angularGrid.slickGrid.onBeforeEditCell.subscribe((e, args) => {
    if (args.item && !this.isCellEditable(args.item, args.column)) {
      return false;
    }
});

just too bad because I need to unsubscribe as well 😦