question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

UI adjustments after commenting on issue

See original GitHub issue
Question Response
Version? master
Devices tested? iPhone 7, Android Nexus 5

What Currently Happens?

While testing #658, I noticed to little glitches happening after a successful comment on an issue:

  • The screen scrolls down, but just above the newly posted comment. I still have to manually scroll to display it
  • Timeago says in 2 seconds (future), on both Android & iOS:
screen shot 2017-12-10 at 11 04 17 am screen shot 2017-12-10 at 11 06 50 am

What Do You Expect To Happen?

  • The new comment should be displayed on the screen, without any further scrolling
  • Timeago should report a date in the past

My Reproduction Steps

  1. Comment on a issue with enough comments to have to scroll down (ex: https://github.com/machour/git-point-playground/issues/34)

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
machourcommented, Dec 10, 2017

@chinesedfan makes perfect sense, thank you!

For time, we could at least detect that we’re about to display a future date and display “now” instead, or something like that.

0reactions
machourcommented, Jan 16, 2018

@chinesedfan fixing the scroll was trickier than expected 😮 see the PR. And it appears that the future-time-ago was fixed by switching to date-fns 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

Comment on UI changes - Chromatic
Pin comments, inspect changes, and rewind through baseline history. ... UI quality by generating a clear checklist of outstanding issues.
Read more >
Support adding comments via the UI · Issue #13 - GitHub
This issue is meant to track what would be required for the first steps in making the UI able to edit reviews rather...
Read more >
Sukritact's Simple UI Adjustments :: Comments
hi.does anyone else have problems with this mod in playbycloud games. some of our games stopped working and are requesting the mod to...
Read more >
"Saving the comment failed" error in code review UI loses ...
Open a Merge Request · Go to the "Changes" tab · Click on a line of code to leave a review comment. ·...
Read more >
Review UI Overview
The Reply…​ button in the change header allows to reply to the currently viewed patch set; one can add a summary comment, publish...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found