v1.4.0 Release - Final Checks

Releasing 1.4.0 has been long overdue, and my apologies 😮. Let’s have this out before the end of this week ⭐️

Couple of things I’ve noticed so let’s use this issue to track down all the changes we’ll need before release 🚀

For any thing mentioned on the list here and on this issue you want to tackle, just tag this issue number on your PR.

On iOS && Android:

Profile images don’t seem to be showing on profile screens

A few list items throughout the app have borders bolded a lot more

Notifications badge count has styling issues

View both screenshots above

Anything else anybody sees, please add it to this ticket. Shouldn’t be too much regressions (and now that we’re adding tests we should definitely be seeing less)

[housseindjirdeh]

😦

Thank you @machour I appreciate it. I definitely think a lot of the folks submitting PRs to change our components styling aren’t actually testing it on their simulator (maybe because it’s simple to quickly grab an issue that requires a quick styling change and they have issues with getting it up and running on their simulator? I know it can be hard for Windows users for example)

I’m going to add a note to the contributing guidelines that asks for a screenshot of the changed component/screen before submitting. If any PR comes up that changes any JSX and/styles, please let’s not merge it in unless there’s a screenshot first.

After that - I agree. I would like the person who actually approves the PR to test it locally on their device/simulator and at least give a nod to other reviewers that it looks good. And I’m guilty here for merging PRs without having tested it with the assumption that other reviewers have, so my apologies 😞

If not a single person who approves it has tested it on their device/simulator - then I agree we should hold off merging.

[machour]

Just ran the app from master after a few days away, and I’m seeing a lot of obvious UI problems:

I think the problem is that we’ve been accepting a lot of PRs for hacktoberfest, from people eager to contribute (and that’s just great) but a bit sloppy with testing.

I believe its the responsibility of the person who decide to click the merge button to:

• checkout the proposed branch
• carefully test everything that was impacted by this PR
• only merge it if it’s fully functional, or give a constructive feedback to the submitter (who will learn a lot from it)

Could we all take some deep breaths before merging ? ❤️