A call to a global function is parsed the same as one without namespace

Hi! If I parse someFunc(); and \someFunc();, both get parsed exactly as:

["call",
  ["ns", ["someFunc"]],
  []]

Which means I don’t have any reference that tells me if I’m calling a function from the global namespace or not.

Perhaps \someFunc(); should get parsed as:

["call",
  ["ns", ["", "someFunc"]],
  []]

(Notice the empty string) What you think about it?

By the way, great parser!

[chris-l]

Well, I think is better if it is mostly an representation of the content, since the behavior could change from one version to another of php. Since php 7 has become stricter, perhaps a future version would not allow the second example of the use statement, and would require adding slash to refer to the global namespace? I don’t know, but is not impossible.

However, as full disclosure, is also true that is more easy for me that way. I’m creating an unparser for the AST created by php-parser, and that way is easier for me.

But even if is easier for me that way, I do think is better if the AST reflects more the content than the behavior, since, like I said, the behavior could be eventually inconsistent among different php versions.

[chris-l]

… After checking, for die or exit the resulting token is T_EXIT, and the AST is the same (didn’t even realize it)

hehe, actually, I did learned it thanks to php-parser 😉 I was testing php-unparser by parsing code with php-parser and then unparsing it to see if the result was correct, and realized you were generating the same AST for both exit and die, so I googled it to see if that was correct… and surprisingly it was!