invalid ast for offsetlookup and encapsed

Input:

$var = "string ${juices['FOO']} string";

Encapsedpart node contains variable node, but should contains offsetlookup node.

PHP parser output:

array(
    0: Stmt_Expression(
        expr: Expr_Assign(
            var: Expr_Variable(
                name: var
            )
            expr: Scalar_Encapsed(
                parts: array(
                    0: Scalar_EncapsedStringPart(
                        value: string 
                    )
                    1: Expr_ArrayDimFetch(
                        var: Expr_Variable(
                            name: juices
                        )
                        dim: Scalar_String(
                            value: FOO
                        )
                    )
                    2: Scalar_EncapsedStringPart(
                        value:  string
                    )
                )
            )
        )
    )
)

Expr_ArrayDimFetch is same as offsetlookup

Maybe will be great add tests for propertylookup and staticlookup to ensure ast correct for lookup nodes.

[alexander-akait]

hm, maybe wen can refactor to one variable: “syntax: curly | dollar | null”

1. curly - "test {$test}";
2. dollar - "test ${test}";
3. null - "test $test";

[alexander-akait]

Thanks, look on this at this week