Improve Variable Names

The current default minLineHeight is 1.33 and default maxLineHeight is 1.25. Unusual to have a min greater than the max. Maybe a typo?

[tinymachine]

UPDATE: Oops, realized I can easily figure this out on my own without parsing the formulas just by checking the resulting line-heights!

---

Hi @theorosendorf and @traviskochel – I’m making progress on updating the variable names and updating the calc() function to handle transposed min/max values. I want to make sure, though, that I’m respecting the relationship between the width-dependent attributes and the container’s width.

Is the relationship between line-height and container width linear? It looks like font-size and variable grade are linearly related, but I’m struggling to parse the line-height (calcleading) calculations:

https://github.com/glyphic-co/textblock/blob/567a0e3354f8c02469f2dc7c5f7c9f041a341f3e/src/textblock.js#L45-L62

If it’s linear, that’s great. (Though it does seem at odds with this statement in the readme: “Textblock gives you the control you need for setting systems like modular scales”.)

Thanks for any light you can shed on the line-height calculations!

[theorosendorf]

K, thanks @traviskochel, and thanks for the help @tinymachine!