Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

NPM scripts don't work on windows os

See original GitHub issue

Describe the bug NPM scripts are not compatible on a windows scripts for two reasons:

Use of single quotes
Setting of environment variables

These have both been mitigated in my PR that I will submit. That said, I’m not sure if this is a complete fix as npm run test keeps failing due to an error with XMLHttpRequest regarding the tests involving DataFrame.fromXXXX. The error I get is below.

At the same time, I feel that this might not be related to the issue at hand, because when I remove the offending lines, the tests (and all other scripts) work just fine. This might just be an issue with my machine. Let me know your thoughts.

Unhandled rejection in tests\dataframeIO.test.js

C:\Users\mkupfer\dataframe-js\node_modules\xmlhttprequest\lib\XMLHttpRequest.js:299

Error: Protocol not supported.

Desktop (please complete the following information):

OS: Windows 7 Professional

Issue Analytics

State:
Created 4 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

mbkupfercommented, Mar 25, 2019

@Gmousse I figured out the final piece to the puzzle! The reason that the XMLHttpRequest error was because the protocol file:// was not being added for windows paths. Adding the path.startsWith("C") to file protocol will finally put this issue to rest 🙌

0reactions

Gmoussecommented, Mar 26, 2019

Your PR #83 is now merged on develop.

It will be included in the next release.