Compile error after updating React - signature of getJSEventName() changed

I’ve updated react to 16.6.0-alpha.8af6728 (This was required as a workaround, as I also updated ReactNative to 0.57.3. Updating ReactNative was required because it includes a workaround for an issue when updating Gradle plugin to 3.2.0)

After updating I got an error in: RecyclerViewBackedScrollViewManager

The error was due to a signature change of the method getJSEventName(). in: getExportedCustomDirectEventTypeConstants() error: ScrollEventType.SCROLL.getJSEventName()

Adding an enum parameter solves the compilation problem, but I don’t know whether this is a good fix. I also don’t know which of the enums makes most sense. I tested with ScrollEventType.SCROLL and it seems to work with some simple use cases. I haven’t done extensive testing yet though.

[henrikra]

Since this fix hasn’t been merged yet I have forked this library and I published the fixed version to npm. You can install version of react-native-recyclerview-list which supports React Native 0.57.3 and up with npm i react-native-recyclerview-fixed.

You can use that version until the maintainer of this library wakes up 😴

[sterbon]

@Sterbon PR #33 fixes this

Thanks!