build.py fails for duplicate provide

Hi all:

Blockly requires that closure-library be present in a sister directory. This is kind of a bummer, vs. requiring it in as a dependency. Regardless, we got it going 😃. Thanks for great instructions!

However, if you run npm install in closure-library, then run python build.py in blockly, it errors out.

$ python build.py
SUCCESS: msg/js/en.js
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "build.py", line 162, in run
    self.gen_core()
  File "build.py", line 184, in gen_core
    [os.path.join("core", "blockly.js")])
  File "../closure-library/closure/bin/calcdeps.py", line 226, in CalculateDependencies
    search_hash = BuildDependencyHashFromDependencies(deps)
  File "../closure-library/closure/bin/calcdeps.py", line 196, in BuildDependencyHashFromDependencies
    dep.filename))
Exception: Duplicate provide (goog.net.DefaultXmlHttpFactory) in (../closure-library/_node_modules/protractor/node_modules/selenium-webdriver/lib/goog/net/xmlhttp.js, ../closure-library/closure/goog/net/xmlhttp.js)

SUCCESS: blockly_uncompressed.js

It has scanned node_modules when looking for dependencies. The resultant js errors out.

Tipskies?

Thanks!

[MarkusBordihn]

I just asked, because I build “closure-builder” for another project which could easily handle the task. If there is enough interest for this I could provide a patch for the needed changes.

For more details see: https://www.npmjs.com/package/closure-builder

[samelhusseini]

Closing as we’ve removed our closure-library dependency.