Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Closure Compiler is not tree shaking
See original GitHub issueSearch entire Blockly codebase for domToPrettyText and there is only the definition in xml.js, along with a few calls in various demos and tests (but notably not the compile test).
Run the compile test then search main_compressed.js for /(<(\w+)\b[^>]*>[^\n]*)\n *<\/\2>/g (a literal that’s exclusively found in domToPrettyText). There’s one match.
Closure Compiler is failing to tree shake. Inspection of the compressed file reveals similar unused functions.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:1
- Comments:6 (4 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@NeilFraser @rachel-fenichel Going off on a tangent here (but I’ll wrap it back around). Are there any plans to migrate Blockly away from using Closure’s module system and move to the ES module standard instead? ES modules seem to have better tooling to support tree-shaking as well as a number of other advantages.
Note that this refers to the advanced compilation test only.
I can confirm that the offending function was removed in PR #5262 and so this bug has been resolved.