Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Extending computed class name identifiers throws:

See original GitHub issue

Input:

var a = {
  foo: class {}
}

class bar extends a['foo']{
  
}

CC throws:

JSC_DYNAMIC_EXTENDS_TYPE: The class in an extends clause must be a qualified name. at line 6 character 18
class bar extends a['foo']{
                  ^

Is this by design? The JS code is valid.

Issue Analytics

State:
Created 7 years ago
Reactions:1
Comments:20 (4 by maintainers)

Top GitHub Comments

4reactions

Treekicommented, Oct 25, 2017

I ran into this issue and decided to take a stab at fixing it (despite never having touched the Closure Compiler codebase before…). As far as I can tell, the most elegant solution is to allow CC to consider terms like a.b['c'] as a qualified name, similar (but not equivalent!) to a.b.c.

I don’t want to submit a PR for this as my fix isn’t perfect – it fails some tests – but perhaps somebody more familiar with the codebase can build upon it and complete it: https://github.com/Treeki/closure-compiler/tree/allow-constant-getelem-in-qualified-names

1reaction

ChadKillingsworthcommented, Jul 3, 2018

See #2997