question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Open source build instructions unclear

See original GitHub issue

I intended to add details to the README regarding the runtime tests and building/testing with NPM/yarn (i.e., via yarn build and yarn test) when I realized I cannot get the Maven build to work anymore, now that pom.xml is no longer in the root directory. Despite my best efforts to repair this (moving POM to pom.xml, adding project.source version to silence “source version must be > 8” errors, etc.) so that mvn -DskipTests and so on execute as expected, I cannot the project to compile successfully.

Any help from someone more experienced with Maven would be greatly appreciated. I will send my README PR as soon as this is working again.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

4reactions
lauraharkercommented, Dec 28, 2020

I believe we only intend to support building via Bazel instead of Maven now: https://github.com/google/closure-compiler#using-bazel. (@nreid260 would know better than me)

Most of the development on Closure Compiler is done in Google’s internal repo via the internal version of Bazel. Most of the Closure Compiler devs are more familiar with Bazel / its internal version, so switching from Bazel to Maven reduced a lot of friction for us & made the internal -> external sync easier, with the tradeoff that non-Google contributors will probably be more familiar with Maven.

Do the Bazel build instructions work for you?

3reactions
nreid260commented, Jan 6, 2021

I can confirm that we no longer intended to support a Maven build. Bazel is the current build tool. We do however continue to publish Maven compatible artifacts to Sontaype.

Read more comments on GitHub >

github_iconTop Results From Across the Web

build instructions unclear · Issue #92 · fahbench ... - GitHub
Hi, current build instructions are not very helpful. After I managed to put proper boost I'm stuck on openmm setup.
Read more >
Some build from source file location instructions unclear (#417 ...
Some build from source file location instructions unclear ... The native library is not open source (not yet anyway) so I cannot share...
Read more >
Instructions unclear, got a dozen milk bottles. - Reddit
You have no idea how many times I wrote whole library to learn in the process that it already exists in open source...
Read more >
Instructions Unclear - Know Your Meme
"Instructions Unclear" is an expression used as a preface when joking about accidentally performing a dangerous or inappropriate action due to an absurd ......
Read more >
Instructions Unclear - Single by Readmi - Spotify
Listen to Instructions Unclear on Spotify. Readmi · Single · 2017 · 4 songs.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found