Add an Automatic-Module-Name manifest entry

Now, that Dagger runs with JDK 9 (as issue #880 is resolved), it might be time to look forward to JPMS compatibility.

In a first step I’d suggest to add a Automatic-Module-Name entry to the jar manifest. This way other libraries depending on Dagger can be published to Maven Central or other repositories. Without it, the automatic module name would be derived from the Dagger .jar file and as such is pretty unreliable.

This proposed change doesn’t affect any code and will simply make a name reservation until an actual module-info.java will be added eventually. More info can be found in this blog post.

[jodastephen]

Just something to bear in mind is that you can’t have two modules with the same name loaded at the same time. The list above suggests you have split packages, where the same package appears in two different jar files. If that is the case, then you can’t really modularise as is.

(The exception to that rule is if the user is expected to choose one of the artifacts, eg one of"dagger-android-jarimpl", “dagger-android-legacy” or “dagger-android-processor”.)

[JakeWharton]

Package name seems more appropriate since it’s agnostic to build system and modules deal in exposing of packages.

On Sun, Mar 4, 2018, 10:59 PM Ron Shapiro [e-mail] wrote:

This sounds fine to me. I presume that we’ll probably want the module names to match the maven artifact names?

• com.google.dagger
• com.google.dagger.compiler
• com.google.dagger.producers
• com.google.dagger.android
• com.google.dagger.android.support

etc.

@netdpb https://github.com/netdpb WDYT?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/dagger/issues/1079#issuecomment-370303676, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEak9rj_DO5SCnhWxtknsUuXzt722ks5tbLgxgaJpZM4SScow .