Combine @BindsInstance & @IntoSet

I have some custom initialization code to be run at a well-defined time. The code is passed to a Component from the outside via @BindsInstance. I’d like to do the following:

@BindsInstance Builder foo(@IntoSet Runnable initCode);

This does not compile due to @IntoSet. @ElementsIntoSet has the same issue. Would it be possible to support this pattern?

There are other Runnable pieces of initialization code within the Component that are in this same set, but I also need to pass in this one piece of external code.

Right now I pass the code in via another binding, and use a separate @Provides @IntoSet method in a module to funnel it into the set. Would be nice to do it directly.

[ronshapiro]

I don’t see a compelling reason not to allow this. This seems reasonable to me. I can look into what it would look like to add support for this but I imagine it wouldn’t be so hard.

[cgdecker]

I think as a workaround you’d just define a module that has an instance @Provides @ElementsIntoSet method that returns the set of values you want contributed to the set, and provide your own way of building an instance of that module such that it returns the set of elements you want. Then you’d create an instance of the module and set it when creating the component.