Dagger Application injection NPE

I’m trying to inject some objects on application, in order to access them whenever I want. So, on my application I’m doing something like this:

private static AppComponent mApplicationComponent;

@Override
    public void onCreate() {
        …
       mApplicationComponent = DaggerAppComponent.builder()
                .appModule(new AppModule(this, new ModuleSpref(this))
                .build();
   }

 public static AppComponent getInstance() {
        return mApplicationComponent;
    }

However, according to google crash log of my production app, the application has a NullPointException when trying to access anything from getInstance(). On my application this happens on a service which is only called via a receiver. Additionally, this also happens on another receiver.

 MyApplication.getInstance().context(); //Null Point Exception :(

Here is my ApplicationComponent:

@Component(modules = AppModule.class)
@Singleton
public interface AppComponent {
    void inject(Context context);

    //Exposed to sub-graphs.
    Context context();
    ModuleSpref getSpref();
}

I tried many times to replicate, but so far without success, despite the google crash saying otherwise. Am I doing something wrong here? As far as I know, for services/receivers to be initialised in android, the application must first be initialised, so getInstance() should not return null right?

[JakeWharton]

No

On Tue, Oct 17, 2017, 12:12 PM Ron Shapiro [e-mail] wrote:

@Zhuinden https://github.com/zhuinden is this what you’re referring too: square/mortar@bf74e3e https://github.com/square/mortar/commit/bf74e3e0ad00713c3123b957a61f82bd73b578b5 ?

Is there any reason to not just call (Application) activity.getApplicationContext() here then and not worry about the null-check?

/cc @rjrjr https://github.com/rjrjr @loganj https://github.com/loganj

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/dagger/issues/748#issuecomment-337272449, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEWPEtAeiU80PqYMRPwQN_rnusoFcks5stNHzgaJpZM4NjrJU .

[Zhuinden]

@camsteffen if I understand the SO solution, it is just moving the component to a static variable? This would work for the production app, but keeping your DI graph in static state tends to cause problems for things like tests.

That’s never bothered anyone using Koin, which works exactly the same way.