[Feature Request] optional provide activity when using ContributesAndroidInjector

When using the ContributesAndroidInjector Annotation there’s no way to provide the activity itself. In the rare cases I need this it’s a pain to always use the “old” approach.

    @Binds
    @IntoMap
    @ActivityKey(MainActivity::class)
    internal abstract fun bindAndroidInjectorFactory(builder: MainActivitySubcomponent.Builder)
            : AndroidInjector.Factory<out Activity>

    @ActivityScope
    @Subcomponent(modules = arrayOf(ActivityModule::class))
    interface MainActivitySubcomponent : AndroidInjector<MainActivity> {
        @Subcomponent.Builder
        abstract class Builder : AndroidInjector.Builder<MainActivity>() {
            abstract fun module(module: ActivityModule): Builder

            override fun seedInstance(instance: MainActivity) {
                module(ActivityModule(instance))
            }
        }
    }

with the module:

@Module
class ActivityModule(private val activity: AppCompatActivity) {
    @Provides
    @ActivityScope
    fun provideActivity(): AppCompatActivity = activity
}

This is a lot of boilerplater why I love the annotation you introduced in 2.11

I would love to see an additional boolean(?) flag in this annotation(may be no IN this annotation but a different one?) which is default false, so that the activity is provided (the code for the subcomponent is generated automatically)

This could be figured out by reading the type of key (@ActivityKey) in the subcomponent

[ronshapiro]

Maybe we could have a way to define an abstract generic module and use a type parameter for the concrete activity type. Then you can specify the module and Dagger will implement it for you:

Something like this:

@Module
@ContributesAndroidInjector.GenericModule // with a better name
interface ActivityModule<T extends Activity> {
  @Binds AppCompatActivity bind(T activity);
  @Binds @MySpecialQualifier Context context(T t);
}

You implement it once, include it in all of your @ContributesAndroidInjector declarations, and Dagger handles the rest. cc: @netdpb

[liminal]

@kingsleyadio not very hard with @ContributesAndroidInjector. Simplest way is to add a component-local module like so:

@Module
abstract class ApplicationModule {

    @ContributesAndroidInjector(modules = [MainActivityModule::class])
    abstract fun provideActivity(): MainActivity
}

@Module
abstract class MainActivityModule {
    @Binds
    abstract fun provideActivity(mainActivity: MainActivity): AppCompatActivity
}

Then you have AppCompatActivity bound in the scope of the MainActivity subcomponent IIRC