Generated code has "Parameter is hiding a field" warnings all over

The below is the generated code for one of my components:

  public CoreModule_ProvideUpdateCheckerFactory(
      Provider<Settings> aSettingsProvider,
      Provider<UpdateChecker.UpdateCallback> aUpdateCallbackProvider,
      Provider<String> aVersionProvider) {
    assert aSettingsProvider != null;
    this.aSettingsProvider = aSettingsProvider;
    assert aUpdateCallbackProvider != null;
    this.aUpdateCallbackProvider = aUpdateCallbackProvider;
    assert aVersionProvider != null;
    this.aVersionProvider = aVersionProvider;
  }

This occurs for just about all generated code.

This code causes a warning for each of the parameters to the tune of:

The parameter SettingsProvider is hiding a field from type CoreModule_ProvideUpdateCheckerFactory

This is caused by the formal parameter having the same name as the field in the class. The code works correctly thanks to qualification using this.. Could the code generation be change to set a prefix or suffix or something on the formal arguments to avoid this warning?

Warning for variable shadowing is default in Eclipse AFAICT.

Dagger version 2.10, Java 8.

[gk5885]

I think your best bet is to just deal with this on the eclipse end. See this Stack Overflow question and this bug. Apparently Eclipse runs afoul of quite a few code generators…

[gk5885]

We hold the generated code to exactly that standard, but only for javac. Eclipse adds a whole bunch of other non-standard checks that change from release to release. We can’t possibly track every new check added by every IDE or static analysis tool, so we drew the line at the standard compiler. I don’t think that’s going to change any time soon, especially given that this is a style check and not a correctness issue.