[Hilt] Bazel HiltViewModel inject java.lang.RuntimeException: Cannot create an instance of class MyViewModel

After following instruction on integrating with Bazel, I’m getting the follwing exception

/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.app, PID: 10134
    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.app/com.example.app.MyActivity}: java.lang.RuntimeException: Cannot create an instance of class com.example.app.MyViewModel
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3449)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
     Caused by: java.lang.RuntimeException: Cannot create an instance of class com.example.app.MyViewModel
        at androidx.lifecycle.ViewModelProvider$NewInstanceFactory.create(ViewModelProvider.java:221)
        at androidx.lifecycle.ViewModelProvider$AndroidViewModelFactory.create(ViewModelProvider.java:278)
        at androidx.lifecycle.SavedStateViewModelFactory.create(SavedStateViewModelFactory.java:112)
        at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:185)
        at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:150)
        at androidx.lifecycle.ViewModelLazy.getValue(ViewModelProvider.kt:54)
        at androidx.lifecycle.ViewModelLazy.getValue(ViewModelProvider.kt:41)
        at com.example.app.MyActivity.getViewModel(MyActivity.kt:51)
        at com.example.app.MyActivity.onCreate(MyActivity.kt:55)
        at android.app.Activity.performCreate(Activity.java:8000)
        at android.app.Activity.performCreate(Activity.java:7984)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3422)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601) 
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85) 
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066) 
        at android.os.Handler.dispatchMessage(Handler.java:106) 
        at android.os.Looper.loop(Looper.java:223) 
        at android.app.ActivityThread.main(ActivityThread.java:7656) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 
     Caused by: java.lang.InstantiationException: java.lang.Class<com.example.app.MyViewModel> has no zero argument constructor
        at java.lang.Class.newInstance(Native Method)
        at androidx.lifecycle.ViewModelProvider$NewInstanceFactory.create

MyViewModel.kt

@HiltViewModel
class MyViewModel @Inject constructor(private val repository: MyRepository) {
   ...
}

MyActivity.kt

@AndroidEntryPoint
class MyActivity : AppCompatActivity() {
    private val viewModel by viewModels<MyViewModel>()
    ...
}

BUILD.bazel

kt_android_library(
    name = "mylib",
	...
    plugins = [
       "//:androidx_hilt_compiler",
    ],
    deps = [
       "//:hilt-android",
	   "@maven//:androidx_hilt_hilt_lifecycle_viewmodel",
    ]
)

Plugin is declared as:

kt_compiler_plugin(
    name = "androidx_hilt_compiler_plugin",
    id = "androidx.hilt.compiler",
    visibility = ["//visibility:public"],
    deps = [
        "@maven//:androidx_hilt_hilt_compiler",
    ],
)

Previously opened issue #2147 is related to Gradle, but didn’t found a solution for Bazel.

Dagger/Hilt version 2.37

[danysantiago]

I think this might also be due to something else…

If androidx_hilt_compiler_plugin is for androidx.hilt:hilt-compiler then that is the wrong processor to apply, the ViewModel functionality was moved to Hilt’s main compiler during the alpha cycles. You should be applying the com.google.dagger:hilt-compiler instead.

Release migration steps in the release notes here: https://github.com/google/dagger/releases/tag/dagger-2.34

[geaden]

I see, thanks. I see you already found the issue filed on the Kotlin rules side bazelbuild/rules_kotlin#514 so I’m not sure there is much we can do on the Hilt side.

Ok, thanks! I’m closing the issue.