[Hilt] Dynamic Feature R8 isMinifyEnabled = true, showing error: is defined multiple times

Version

Hilt: 2.28.3-alpha in :base module Using vanilla dagger in :dynamic-feature module AGP: 4.0.1 GWP: 6.5.1 Kotlin: 1.3.72

Problems

Context

R8 isMinifyEnabled = false, succeed to build & runs, otherwise it fails as described in the title

Question

1. Is it currently not supported to define same dependency class in multiple class and used injected across dynamic feature module?
2. Is it R8 restriction due to multiple class defined? and how to solve that?

Our usecase:

:data is a java only module

class MapperA @Inject constructor()

class AuthRepositoryImpl @Inject constructor(
    private val mapper: MapperA
) : AuthRepository

class AccountRepositoryImpl @Inject constructor(
    private val mapper: MapperA
) : AccountRepository

:dynamic-feature:auth module

@DisableInstallInCheck
@Module
interface AuthModule {
    @get:[Binds]
    val AuthRepoistoryImpl.repository: AuthRepository
}

:dynamic-feature:account module

@DisableInstallInCheck
@Module
interface AccountModule {
    @get:[Binds]
    val AccountRepoistoryImpl.repository: AccountRepository
}

I’ve tried to implement @Qualifers to annotate it as different dependencies but doesn’t work either, see here #2074

[Chang-Eric]

Since it is MapperA_Factory that is being duplicated, my guess as to what is going on here is that you aren’t running the Dagger processor over the MapperA class and are pulling it into two different Dagger components.

Factory generation for @Inject classes can happen in two places: on the class itself if you run the Dagger processor (preferred) or lazily when used by the Dagger component. The problem with the second case is that if you have two Dagger components built separately we’ll generate the same factory twice. (There’s also a separate problem that generating it at the component can reduce build parallelism if you have a lot of factory classes to generate too, but that isn’t your direct issue right now).

[mochadwi]

I don’t think it is in the documentation (not sure there is a great place to put it right now), but you should have gotten a build warning about it at least https://github.com/google/dagger/blob/master/java/dagger/internal/codegen/validation/InjectBindingRegistryImpl.java#L130

Nice! Closing this issue now~