Hilt with Custom Views and @AndroidEntryPoint, generating @Nullable annotation twice

Hi there 👋 I’m trying to migrate my project to use Hilt from Dagger Android.

I’ve run into an issue where adding @AndroidEntryPoint onto a custom view, produces a compilation issue on the generated custom view component.

The custom view looks similar to the following:

@AndroidEntryPoint
class CustomShapeView @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null, defStyleAttr: Int = 0) :
    CustomBaseView<ShapeLayer>(context, attrs, defStyleAttr) {
    @Inject
    lateinit var customInjectedClass: CustomInjectedClass

And now when I run the build, it breaks with the generated class for the view looking as follows:

/**
 * A generated base class to be extended by the @dagger.hilt.android.AndroidEntryPoint annotated class. If using the Gradle plugin, this is swapped as the base class via bytecode transformation.
 */
@Generated("dagger.hilt.android.processor.internal.androidentrypoint.ViewGenerator")
public abstract class Hilt_CustomShapeView<T> extends CustomBaseView<T> implements GeneratedComponentManager<Object> {
  private ViewComponentManager componentManager;
  Hilt_CustomShapeView(@NotNull Context arg0, @Nullable @Nullable AttributeSet arg1,
      int arg2) {
    super(arg0, arg1, arg2);
    inject();
  }
  Hilt_CustomShapeView(@NotNull Context arg0, @Nullable @Nullable AttributeSet arg1) {
    super(arg0, arg1);
    inject();
  }
  Hilt_CustomShapeView(@NotNull Context arg0) {
    super(arg0);
    inject();
  }

You can see the first two generated constructors for the view has the @Nullable annotation twice on the AttributeSet. The compilation error is the following:

error: Nullable is not a repeatable annotation type
  Hilt_CustomShapeView(@NotNull Context arg0, @Nullable @Nullable AttributeSet arg1,

I tried to remove the @JvmOverloads annotation and create the constructors one by one, but that didn’t seem to make a difference either.

I’m not sure if I’m missing something, but I think this is a bug.

[ZacSweers]

JavaPoet 1.13.0 is available now on maven central: https://repo1.maven.org/maven2/com/squareup/javapoet/1.13.0/

Thanks to @egorand for the quick turnaround on it!

[ZacSweers]

Heard back and they’re going to target releasing this week 👍