How can we add a module to Subcomponent.Builder in version 2.10-rc2?

With the new functionality, we can inject Activity and Fragment using a single AndroidInjection.inject(this) call. But how can we pass a module to Subcomponent’s builder?

For example, Activity’s subcomponent has a module which needs this Activity in the constructor.

@ActivityScope
@Subcomponent(modules = SplashActivitySubcomponent.SplashActivityModule.class)
public interface SplashActivitySubcomponent extends AndroidInjector<SplashActivity> {
    @Subcomponent.Builder
    abstract class Builder extends AndroidInjector.Builder<SplashActivity> {
    }

    @Module
    abstract class SplashActivityModule extends ActivityModule<SplashActivity> {
        SplashActivityModule(SplashActivity activity) {
            super(activity);
        }

        @ActivityScope
        @Provides
        SplashContract.View provideView() {
            return activity;
        }

        @ActivityScope
        @Provides
        SplashContract.Presenter providePresenter(SplashPresenter presenter) {
            return presenter;
        }
    }
}

[JonathanMerritt]

Sorry to tag on this issue, I am currently doing something else to achieve the same effect.

Is it a bad idea?

@ActivityScope @Subcomponent(modules = { MyActivityModule.class })
public interface MyActivityComponent extends AndroidInjector<MyActivity> {
  @Subcomponent.Builder abstract class Builder extends AndroidInjector.Builder<MyActivity> {
    public abstract Builder myActivityModule(MyActivityModule myActivityModule);

    @Override public void seedInstance(MyActivity instance) {
      myActivityModule(new MyActivityModule(instance));
    }

    public abstract MyActivityComponent build();
  }
}

If I should post on SO or create anew issue just tell me.

[ronshapiro]

@AntonyGolovin I’d suggest you look at the linked issue that @JakeWharton mentioned.

@JonathanMerritt - that does work, but it’s unnecessary. the seedInstance method provides the activity instance into the graph, so you can have MyActivityModule with no state, and just request MyActivity in your @Provides methods.

class MyActivityModule {
  @Provides
  static SomethingDerivedFromMyActivity providesMethod(MyActivity myActivity) {
    return myActivity.somethingDerived();
  }
}

Doing this saves the module instance and allows the generated factories to be leaner.