question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Specify the correct sample name for empty VCFs instead of `default`

See original GitHub issue

Describe the issue: DeepVariant currently outputs default as the sample name for empty VCFs (related to the fix in #186 ). Ideally, the sample_name should be transferred from the original BAM file, but if that is too difficult to implement (since there are no examples), I think it would also be ok if we let the user customize this ID. One suggestion is that it can use the value provided by the --sample_name flag (currently, used for make_examples, but I think it can also be reused for postprocess_variants).

Using default causes issues in pipelines where the VCF is used downstream of DeepVariant (e.g. merging the VCF with other callers; or even within DeepVariant in a pipeline that scatters calling across multiple chromosomes and tries to gather them and some of those VCFs are empty).

Setup

  • DeepVariant version: v0.10.0
  • Installation method (Docker, built from source, etc.): docker

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
gunjanbaidcommented, Aug 19, 2020

The functionality has been implemented in the internal codebase and will be available in the next release.

1reaction
pichuancommented, Aug 14, 2020

Thanks for the suggestion @arostamianfar . Sounds like a good suggestion and should be easy to do : adding a flag to postprocess_variants. If sample_name is specified for run_deepvariant.py, we’ll use it for both.

I’ll file an internal issue to track this, and we should be able to have this in our next release.

Read more comments on GitHub >

github_iconTop Results From Across the Web

gatk HaplotypeCaller gives me an empty vcf
Hi, I am using GATK Version 4.0.0 on mouse data. I ran HaplotypeCaller with ERC option; It gave me an empty vcf (only...
Read more >
bcftools(1) Manual Page - Samtools
BCFtools is a set of utilities that manipulate variant calls in the Variant Call Format (VCF) and its binary counterpart BCF. All commands...
Read more >
vcfR: Manipulate and Visualize VCF Data
This function populates the missing elements by concatenating the chromosome and position.
Read more >
User guide — whatshap 1.7 documentation - Read the Docs
Edit the sample names in the VCF header. Set the correct read group info in the BAM/CRAM file, for example with the Picard...
Read more >
Standard data input - PLINK 2.0 - cog-genomics.org
If you want to export a sites-only VCF instead, see --make-pgen/--make-just-pvar's 'vcfheader' column set. Dosage are not exported unless the 'vcf-dosage=' ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found