Should @ForOverride foo() permit super.foo() calls?

Guava has this situation:

class AbstractFuture {
  // @ForOverride?
  void done() {}
}

// There are multiple classes like the following:
class AggregateFuture extends AbstractFuture {
  @Override final void done() {
    super.done();

    runningState = null;
  }
}

We would like to apply @ForOverride to done(). But we can’t because of the super.done() call[]. We don’t really *need that call, but it makes me feel safer to have it there. (I would also want it if we had multiple levels of done() overrides down the hierarchy… though I suppose we could have done() call a reallyDone() method.) Another option is for us to make done() abstract so that we “know” we don’t need the super.done() call. But we still don’t really “know” that unless we look at the superclass. Plus, it requires every subclass to override done(), even though most don’t need to.

Possibilities for changes that might help us:

• Allow super.done()
• Allow super.done() if the calling method is itself annotated @ForOverride (but this would be weird in our case, where done() is sometimes final)

[*] Error:

error: [ForOverride] Method annotated @ForOverride must not be invoked directly (except by the declaring class, com.google.common.util.concurrent.AbstractFuture<V>)
    super.done();
              ^

[cushon]

What about only allowing super.done() inside an override of done?

[eaftan]

Thanks @lukesandberg