Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

FFMpeg error with some flac files

See original GitHub issue

ExoPlayer Version

2.18.1

Devices that reproduce the issue

All

Devices that do not reproduce the issue

None

Reproducible in the demo app?

Not tested

Reproduction steps

Play the file send by mail with the ffmpeg extension enabled. Skip or wait until near the end of the file and see an error.

Expected result

No error (And no error with default Android mediacodec)

Actual result

ExoPlayerImplInternal - Playback error
                                                                               com.google.android.exoplayer2.ExoPlaybackException: FfmpegAudioRenderer error, index=0, format=Format(null, null, null, audio/flac, null, -1, null, [-1, -1, -1.0], [2, 48000]), format_supported=YES
                                                                                   at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:566)
                                                                                   at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                                   at android.os.Looper.loopOnce(Looper.java:201)
                                                                                   at android.os.Looper.loop(Looper.java:288)
                                                                                   at android.os.HandlerThread.run(HandlerThread.java:67)
                                                                               Caused by: com.google.android.exoplayer2.ext.ffmpeg.FfmpegDecoderException: Unexpected decode error
                                                                                   at com.google.android.exoplayer2.ext.ffmpeg.FfmpegAudioDecoder.createUnexpectedDecodeException(FfmpegAudioDecoder.java:95)
                                                                                   at com.google.android.exoplayer2.ext.ffmpeg.FfmpegAudioDecoder.createUnexpectedDecodeException(FfmpegAudioDecoder.java:32)
                                                                                   at com.google.android.exoplayer2.decoder.SimpleDecoder.decode(SimpleDecoder.java:245)
                                                                                   at com.google.android.exoplayer2.decoder.SimpleDecoder.run(SimpleDecoder.java:202)
                                                                                   at com.google.android.exoplayer2.decoder.SimpleDecoder.access$000(SimpleDecoder.java:29)
                                                                                   at com.google.android.exoplayer2.decoder.SimpleDecoder$1.run(SimpleDecoder.java:73)
                                                                               Caused by: java.lang.IllegalArgumentException
                                                                                   at java.nio.Buffer.limit(Buffer.java:290)
                                                                                   at java.nio.ByteBuffer.limit(ByteBuffer.java:820)
                                                                                   at com.google.android.exoplayer2.ext.ffmpeg.FfmpegAudioDecoder.decode(FfmpegAudioDecoder.java:139)
                                                                                   at com.google.android.exoplayer2.ext.ffmpeg.FfmpegAudioDecoder.decode(FfmpegAudioDecoder.java:32)
                                                                                   at com.google.android.exoplayer2.decoder.SimpleDecoder.decode(SimpleDecoder.java:241)
                                                                                   at com.google.android.exoplayer2.decoder.SimpleDecoder.run(SimpleDecoder.java:202) 
                                                                                   at com.google.android.exoplayer2.decoder.SimpleDecoder.access$000(SimpleDecoder.java:29) 
                                                                                   at com.google.android.exoplayer2.decoder.SimpleDecoder$1.run(SimpleDecoder.java:73)

Media

Send by mail.

Bug Report

You will email the zip file produced by adb bugreport to dev.exoplayer@gmail.com after filing this issue.

Issue Analytics

State:
Created 10 months ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

Tolriqcommented, Nov 8, 2022

@rohitjoins actually there’s nothing more to do, the fix does return the proper code that is supported by the decoder and in the case of that file properly ignore the invalid data at the end of it.

So simple fix to greatly improve resilience of the ffmpeg extension.

0reactions

rohitjoinscommented, Nov 8, 2022

@Tolriq Thank you for sending the PR. I agree with the fix in the error message and will accept the PR soon. Overriding behaviour of ffmpeg to handle invalid data seems tricky and hard to maintain in the future. I believe we should mirror the ffmpeg extension when enabled.