Where to find clear documentation about migration in IMA Extension?
See original GitHub issueUnfortunately we can’t answer all questions. Unclear questions or questions with insufficient information may not get attention.
Before filing a question:
- Ask general Android development questions on Stack Overflow
- Search existing issues, including issues that are closed https://github.com/google/ExoPlayer/issues?q=is%3Aissue
- Consult our developer website (https://exoplayer.dev/) and Javadoc (https://exoplayer.dev/doc/reference/)
When filing a question:
Describe your question in detail.
In case your question refers to a problem you are seeing in your app:
- Output of running
$ adb bugreport
in the console
In case your question is related to a piece of media:
- URI to test content
- For protected content:
- DRM scheme and license server URL
- Authentication HTTP headers
Don’t forget to check supported formats and devices (https://exoplayer.dev/supported-formats.html).
If there’s something you don’t want to post publicly, please submit the issue, then email the link/bug report to dev.exoplayer@gmail.com using a subject in the format “Issue #1234”, where #1234 is your issue number (we don’t reply to emails).
v2.13.3
has a lot of changes is there any documentation that explain the migration?
Before this is my code
adsLoader = new ImaAdsLoader(this.context, adsUri);
but now this does not work, why removing it?
Another is this
DataSource.Factory getDataSourceFactory() {
return new DefaultDataSourceFactory(context, getHttpDataSourceFactory());
}
private DataSource.Factory getHttpDataSourceFactory() {
return new DefaultHttpDataSource.Factory().setUserAgent(Util.getUserAgent(context, context.getString(R.string.app_name)));
}
adsMediaSource = new AdsMediaSource(mediaSourceBuilder.getMediaSource(), mediaSourceBuilder.getDataSourceFactory(), adsLoader, playerView);
Now it requires 6 parameters but where do I get those parameters while DataSource.Factory
is no longer included.
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (3 by maintainers)
Top GitHub Comments
It looks right for passing the ads URI, but you are passing
null
for theadsId
parameter, which is not nullable. The value passed there is used as a key for tracking the ad playback state (so if your release the player due to entering the background then come back to the foreground, you should pass the sameadsId
so that the old ad playback state before backgrounding is restored, for example). I think you can probably just pass youradsUri
foradsId
as well, so that resuming playback with the same ads URI restores the old ad playback state.VMAP ad tags can indeed configure multiple ads, and that has been supported since the first version of the IMA extension. I’m not aware of this feature in VAST (I think that always has a single ad and we play it as a preroll), but it is not really the concern of ExoPlayer anyway as we delegate loading/parsing to the IMA SDK.
The new functionality tracked by #3750 lets you play multiple media sources or media items each with their own ad tag, so that is different from what you are describing.
To keep this issue focused, please file a new issue if there are any unrelated follow-up questions.