[Code health] Consistent naming of local DB converters

Pretty much every local db entity has to/from conversion methods for converting a corresponding model object to the local db entity type. However, we don’t name these consistently. Sometimes they are named toModel, sometimes toObject sometimes to<ModelTypeName>…

We should pick a consistent naming scheme. For extra clarity, my vote goes toward to<ModelTypeNameModel>Model; e.g.

toLocationOfInterestModel; fromLocationOfInterestModel; toAuditInfoModel; fromAuditInfoModel

[gino-m]

I think that makes sense. I haven’t made up my mind about using inheritance solely for the purpose of enforcing naming conventions (ie LocalDbConverter would never be referenced except by implementors), but the pattern make sense.

Nit: Following Java naming conventions (assuming they’re the same in Kotlin) here we’d have LocalDb and not LocalDB.

Thanks for working through this!

[gino-m]

The last proposal sgtm, all things considered.

On Fri, Sep 23, 2022, 11:35 AM Scott Olsen @.***> wrote:

We could land somewhere in the middle:

model.toLocalDataStoreObject() entity.toModelObject()

— Reply to this email directly, view it on GitHub https://github.com/google/ground-android/issues/1276#issuecomment-1256368221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXVUQ7AC6TR6JXJXB5VPTV7XE4JANCNFSM6AAAAAAQNOF5UQ . You are receiving this because you were mentioned.Message ID: @.***>