question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Code health] Harmonize geometry representation

See original GitHub issue

Shapes are represented in remote db in features as point (GeoPoint), geoJson (string) and geometry (map). There’s also some confusion in the implementation about geometries vs LOIs. This design wasn’t intentional and we can improve it.

Ideas:

  • Define generic geometry types independent of Ground model (perhaps import ~GeoTools?~ JTS)
  • Instead of extending LocationOfInterest, have it contain an arbitrary Geometry
  • Replace separate point, geoJson db format mirror GeoJSON where appropriate, but use Firebase GeoPoint for coordinates. Avoid nested arrays since they’re unsupported by Firebase.
  • Load/save in local db (@scolsen)
  • Update map to render new Geometry types (@jsunde)
  • Delete old subclasses of LocationOfInterest (@scolsen)

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:18 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
scolsencommented, Sep 22, 2022

I think we can consider this one closed!

1reaction
JSundecommented, Sep 22, 2022

I just merged the updates to the PolygonDrawingViewModel, #1279, to remove the MapPolygon and render a LineString for incomplete polygons and convert them to a LinearRing when they are completed.

I think that may have been the last of the rendering changes required.

Let me know if you think there is anything I missed! Otherwise I think we can probably close this issue.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Dr Ibrahim Karim & Rene Stevens - BioGeometry - YouTube
BioGeometry : Solutions to Harmonize Environment Distortions - Dr Ibrahim ... learn/work environment, health, food, and our devices (such as ...
Read more >
Sacred Geometry Explained - What is the Meaning Behind the ...
Sacred geometry brings about certain effects of healing, harmonizing and rebalancing on all levels. It connects the inner and outer, uniting all.
Read more >
Deep representation learning of patient data from Electronic ...
Patient representation learning refers to learning a dense mathematical representation of a patient that encodes meaningful information from Electronic Health ...
Read more >
Deep Representation Learning of Patient Data from ... - arXiv
In Electronic Health Records (EHRs), information regarding patient status is extensively documented. Therefore, EHR data provides a feasible mechanism to track ...
Read more >
Journal of Biomedical Informatics - NSF PAR
Objectives: Patient representation learning refers to learning a dense mathematical representation of a patient.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found