Absent#equals bugs after serializing / deserializing

After serializing / deserializing Absent instances won’t be the same (e.g. in an Apache Spark context with Kryo serialization).

Therefore the implementation below contains a bug. Why not just check if the two instances have the same class definition?

@Override public boolean equals(@Nullable Object object) {
  return object == this;
}

[kevinb9n]

Although Chris is right that making the specific change requested here wouldn’t hurt, I’m terrified to hear that people are serializing Guava types in ways like this. They’re going to have a lot of problems. I’m worried about creating any impression that Guava tries to work correctly in this kind of environment.

On Wed, Apr 5, 2017 at 11:34 AM, Michał Sobkiewicz <[e-mail]

wrote:

Absent extends Optional, so it can’t extend Enum.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/google/guava/issues/2779#issuecomment-291954620, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5Cl86Rsh3BZOIONw6-KE-GZgTb3LATks5rs96igaJpZM4M0Mw_ .

– Kevin Bourrillion | Java Librarian | Google, Inc. | [e-mail]

[cbismuth]

@lowasser I understand and totally agree, thank you.