ImmutableGraph inherits implementation methods from AbstractBaseGraph

com.google.common.graph.ImmutableGraph inherits some protected methods from the package-private class AbstractBaseGraph, these methods are therefore part of ImmutableGraph’s public API. Affected:

• edgeCount()
• validateEndpoints(EndpointPair)
• isOrderingCompatible(EndpointPair)

These methods should probably be package-private since they appear to be part of the internal implementation. It would probably be good to mark them as @Deprecated first and then remove them later.

[cpovirk]

Thanks, and thanks. It’s sounding like further changes here would require someone with actual knowledge about common.graph. (And as you may be aware, we haven’t reliably made time for common.graph when actually knowledgeable people have been available.) If we do put some dedicated effort into common.graph, that may be a good time to pick this up.

[jbduncan]

I used edgeCount() in a small project of mine (and I almost used validateEndpoints at some point), so I can attest that deprecating it or making it package-private would complicate things.